Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-filters: Add white balance to color filter #10695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mar10iana
Copy link
Contributor

Description

We added three white balance sliders to the color correction filter, as shown on the screenshots below:

IMG_8447
IMG_1899

The following changes have been made to the code:

  • Added new settings for red, green, and blue white balance adjustments.
  • Updated the color_correction_filter_data structure to include white balance variables.
  • Modified the create functions to initialize the white balance values.
  • Implemented white balance matrix computation in the update functions.
  • Integrated the white balance matrix into the final matrix used for color correction.
  • Updated the properties functions to add sliders for white balance adjustments.
  • Set default values for the new white balance settings.

Motivation and Context

Currently, OBS offers a variety of color correction filters, but lacks a dedicated white balance feature, which is essential for many users. This feature aims to address this problem by introducing three white balance sliders (red, green and blue) that adjust the color temperature.

Ideas website link: https://ideas.obsproject.com/posts/2582/white-balance

How Has This Been Tested?

We tested our feature in a macOS environment.
To test this feature you should go to the color correction filter and check the newly added sliders. If you change the value of the slider, the colours of your source will be updated.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the New Feature New feature or plugin label May 24, 2024
@tytan652 tytan652 added the UI/UX Anything to do with changes or additions to UI/UX elements. label May 25, 2024
@WizardCM
Copy link
Member

Is it common for white balance to be split into three separate sliders? Keeping in mind OBS is used by a variety of users, some with very intricate knowledge of video/colour and others who just want to make it look good with as little configuration as possible.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use merge commits to catch up on branch/repo history. Use git rebase.

This commit introduces a white balance adjustment option to the
color correction filter. The following changes have been made:

- Added new settings for red, green, and blue white balance
  adjustments.
- Updated the color_correction_filter_data structure to include
  white balance variables.
- Modified the create functions to initialize the white balance
  values.
- Implemented white balance matrix computation in the update
  functions.
- Integrated the white balance matrix into the final matrix used
  for color correction.
- Updated the properties functions to add sliders for white
  balance adjustments.
- Set default values for the new white balance settings.

These changes allow users to fine-tune the white balance of their
video sources, providing more control over the color correction
process.

Co-authored-by: Mariana Mendonca <mariana.mendonca@tecnico.ulisboa.pt>
@mar10iana
Copy link
Contributor Author

Is it common for white balance to be split into three separate sliders? Keeping in mind OBS is used by a variety of users, some with very intricate knowledge of video/colour and others who just want to make it look good with as little configuration as possible.

This method offers the highest level of control, allowing precise fine-tuning of color balance across the spectrum. It's ideal for professional users who need to correct complex color casts or achieve specific color grading effects.
For regular users, like myself, despite not being the simplest option, I still find this method pretty straightforward to use.
But ultimately it is up to you guys! We can change it if needed :)

@mar10iana mar10iana requested a review from RytoEX May 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants