Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Analog Clock Widget #3546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adharmic
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/adharmic/obsidian-analog

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ It seems like you made a typo in the repository field https://github.com/adharmic/obsidian-analog.
❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: https://github.com/adharmic/obsidian-analog. If you are submitting from a GitHub org, you need to be a public member of the org.
❌ It seems like you made a typo in the repository field https://github.com/adharmic/obsidian-analog.
❌ You don't have a manifest.json at the root of your repo, or it could not be parsed.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the Obsidian Website. If you don't have a website you can just point it to your GitHub profile.
❌ The fundingUrl field in your manifest should not point to the Obsidian Website, If you don't have a link were users can donate to you, you can just remove it from the manifest.
❌ Unable to find a release with the tag 1.0.4. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@adharmic adharmic closed this May 20, 2024
@adharmic adharmic reopened this May 20, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.5. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@adharmic adharmic closed this May 20, 2024
@adharmic adharmic reopened this May 20, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.5. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@adharmic adharmic closed this May 20, 2024
@adharmic adharmic reopened this May 20, 2024
@github-actions github-actions bot changed the title Add Analog Clock Widget plugin Add plugin: Analog Clock Widget May 20, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this May 20, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin
Projects
None yet
2 participants