Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Inbox Organiser #3545

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kulak-at
Copy link

I am submitting a new Community Plugin

Repo URL

obsidian-inbox-organiser
Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ It seems like you made a typo in the repository field h-sphere/inbox-organiser.
❌ You don't have a manifest.json at the root of your repo, or it could not be parsed.


Warnings:

⚠️ Your repository does not include a license. It is generally recommended for open-source projects to have a license. Go to https://choosealicense.com/ to compare different open source licenses.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 0.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@kulak-at kulak-at closed this May 19, 2024
@kulak-at kulak-at reopened this May 19, 2024
@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: Inbox Organiser May 19, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:This class is only available on desktop, which means that this will throw errors on mobile (that's a problem since you have isDesktopOnly marked as false in your manifest.json file.

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually the adapter you expect.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this May 20, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels May 20, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels May 27, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment May 27, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented May 29, 2024

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number.

constructor(app: App, plugin: InboxOrganisePlugin) {
Remove this constructor, the default constructor does the same thing, the only difference is this line: this.settings = Object.assign({}, DEFAULT_SETTINGS); which will only causes race conditions.

new Notice("Nothing to Organise",1500), export const BUTTON_TEXT_CANCEL = 'Cancel Organising', super('Organise Cancelled');, .setName('Inbox Folder')
Use sentence case in UI

await adapter.rename(file.path, newPath);
Use the this.app.vault.rename method instead, since you already have the TAbstractFile.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
3 participants