Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Hexo Publisher #3541

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zhenlohuang
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/zhenlohuang/obsidian-hexo-publisher

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Obsidian in your plugin name since it's redundant and adds clutter to the plugin list.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (hexo-publisher) is not the same as the one in your repo (obsidian-hexo-publisher). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Hexo Publisher) is not the same as the one in your repo (Obsidian Hexo Publisher). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@zhenlohuang zhenlohuang changed the title Add Obsidian Hexo Publisher Plugin Add Hexo Publisher Plugin May 18, 2024
@github-actions github-actions bot changed the title Add Hexo Publisher Plugin Add plugin: Hexo Publisher May 18, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 22, 2024
@zhenlohuang
Copy link
Author

zhenlohuang commented May 31, 2024

Thanks for your review. For this comment, I need to access the file outside Obsidian, which API should I use?

[import * as path from 'path';](https://github.com/zhenlohuang/obsidian-hexo-publisher/blob/531a592aa3cccc8358d203b96bd34db419e82646/src/hexo.ts#L1-L73)
You should be using the vault API instead of the Node fs/path API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
3 participants