Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Settings Management #3530

Merged
merged 1 commit into from
May 28, 2024
Merged

Add plugin: Settings Management #3530

merged 1 commit into from
May 28, 2024

Conversation

xhuajin
Copy link
Contributor

@xhuajin xhuajin commented May 15, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/xhuajin/obsidian-settings-management

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented May 16, 2024

"name": "Settings Options Management",
Remove "Options", it makes no sense here, since "Settings" is already in the name.
Also, the plugin is not doing any "Management" it's just displaying some settings differently.

"description": "Allows you to better manage your settings options panel.",
Same here, also, a description should not start with "Allows you"

// Remember to rename these classes and interfaces!
Remove this comment.

console.log(floating toc disable loading on mobile);

addIcon('toggle-none', '')
Obsidian already includes Lucide, no need to add this icon here.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 16, 2024
@xhuajin
Copy link
Contributor Author

xhuajin commented May 18, 2024

Hi @joethei, i fix those requests in v1.0.1

I check the lucide and i can't find the 'toggle-center' or 'toggle-none' icon. Lucide just provide 'toggle-left' and 'toggle-right' icon. I need a toggle icon that circle in the middle to represent the state that have enabled plugins and disabled plugins at the same time when toggle-right represent show enabled plugins, toggle-left represent show disabled plugins.

I change i name and id from 'Settings Options Mnagement' to 'Settings Management'. Also, I add some new function to reflect the "Management".

@github-actions github-actions bot changed the title Add plugin: Settings Options Management Add plugin: Settings Management May 18, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 18, 2024
@joethei
Copy link
Collaborator

joethei commented May 27, 2024

if (Platform.isMobileApp || this.app.isMobile) {
You can remove this conditions, as isDesktopOnly is already set.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made labels May 27, 2024
@xhuajin
Copy link
Contributor Author

xhuajin commented May 27, 2024

Get it. I remove it.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 27, 2024
@joethei joethei merged commit c287f21 into obsidianmd:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants