Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Interactivity #3529

Merged
merged 1 commit into from
May 22, 2024
Merged

Add plugin: Interactivity #3529

merged 1 commit into from
May 22, 2024

Conversation

ichichikin
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin:
https://github.com/ichichikin/obsidian-plugin-interactivity

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.
❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ichichikin ichichikin marked this pull request as draft May 14, 2024 23:45
@ichichikin ichichikin marked this pull request as ready for review May 14, 2024 23:51
@ichichikin ichichikin closed this May 14, 2024
@ichichikin ichichikin reopened this May 14, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Lookbehinds are not supported in iOS versions before 16.4


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this May 15, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels May 15, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment May 15, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented May 16, 2024

"authorUrl": "",
This needs to be filled, you can use your GH profile url.

"description": "The Interactivity plugin allows you to run any executables inside your Obsidian notes.",
Don't include "plugin" in the description, it should be self evident that this is a plugin.

"minAppVersion": "0.12.17",
You are using newer API's, set this to the latest public build number.

"@types/node": "^20.1.7",
Why all these dependencies?
Remove all that are not actually used.

// Remember to rename these classes and interfaces!
Remove this comment.

id: 'interactivity-execute',, id: 'interactivity-restart',
Remove the prefix, this should just be execute/restart.

this.app.vault['adapter']['basePath'] + '/' + this.app.vault['configDir'] + '/plugins/interactivity/1'
This should be

if (this.app.vault.adapter instanceof FileSystemAdapter) {
	const p = normalizePath(this.app.vault.adapter.getBasePath() + '/' + this.manifest.dir + '/1');

containerEl.createEl('h2', {text: 'Interactivity settings'});
Don't include a header with the plugin name in the settings

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels May 16, 2024
@ichichikin
Copy link
Contributor Author

@joethei, thank you for detailed comments. All is fixed.

@ObsidianReviewBot ObsidianReviewBot added Changes made and removed Minor changes requested PR can be merged after some final changes have been requested labels May 17, 2024
@joethei
Copy link
Collaborator

joethei commented May 17, 2024

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made labels May 17, 2024
@ichichikin
Copy link
Contributor Author

@joethei, fixed

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 18, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token : in JSON at position 424991


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ichichikin
Copy link
Contributor Author

@joethei, a kindly reminder

@joethei joethei merged commit 17a82cf into obsidianmd:master May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants