Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Sheet Plus #3521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ljcoder2015
Copy link
Contributor

@ljcoder2015 ljcoder2015 commented May 13, 2024

excel plus

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/ljcoder2015/obsidian-sheet-plus

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 423236


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ljcoder2015 ljcoder2015 changed the title Update community-plugins.json Add plugin: Excel Plus May 13, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this May 13, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels May 13, 2024
@ljcoder2015
Copy link
Contributor Author

ljcoder2015 commented May 13, 2024

/skip
I need to use outerHTML to convert to an HTML string for the copy function

@ljcoder2015
Copy link
Contributor Author

/skip I need to use outerHTML to convert to an HTML string for the copy function

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label May 14, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels May 16, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment May 16, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels May 21, 2024
@ljcoder2015
Copy link
Contributor Author

update!
The current plugin supports embedding into other notes.
Supports global search.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 22, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels May 28, 2024
@joethei
Copy link
Collaborator

joethei commented May 28, 2024

The name of the repository and the README has not been updated.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made Minor changes requested PR can be merged after some final changes have been requested labels May 28, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (excel-plus) is not the same as the one in your repo (sheet-plus). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Excel Plus) is not the same as the one in your repo (Sheet Plus). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ljcoder2015 ljcoder2015 changed the title Add plugin: Excel Plus Add plugin: Sheet Plus May 29, 2024
@ljcoder2015
Copy link
Contributor Author

Have been updated

@ljcoder2015
Copy link
Contributor Author

@joethei What else needs to be updated?

@ljcoder2015 ljcoder2015 reopened this Jun 5, 2024
@ljcoder2015
Copy link
Contributor Author

Have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants