Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update devcontainer #23479

Merged
merged 2 commits into from
May 21, 2024
Merged

chore(core): update devcontainer #23479

merged 2 commits into from
May 21, 2024

Conversation

isaacplmann
Copy link
Collaborator

Updates the devcontainer so that it has the correct version of pnpm

Fixes #20419

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 8:07pm

@isaacplmann isaacplmann enabled auto-merge (squash) May 17, 2024 13:47
@isaacplmann isaacplmann self-assigned this May 17, 2024
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this actually works pretty well :)

@isaacplmann isaacplmann merged commit 89fdd42 into master May 21, 2024
6 checks passed
@isaacplmann isaacplmann deleted the docs/devcontainer branch May 21, 2024 22:37
FrozenPandaz pushed a commit that referenced this pull request May 22, 2024
Updates the devcontainer so that it has the correct version of pnpm

Fixes #20419

(cherry picked from commit 89fdd42)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for dev containers setup
3 participants