feat(core): allow partially resetting workspace #23381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
a team,
FrozenPandaz,
xiongemi and
Coly010
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e5ae718. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
e8c03a6
to
ff7787c
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
ff7787c
to
2453d62
Compare
FrozenPandaz
requested changes
May 14, 2024
| { name: 'workspaceData', message: 'Workspace Data' }, | ||
| ], | ||
| footer: 'Press <space> to select, <return> to submit.', | ||
| indicator(state, choice) { |
There was a problem hiding this comment.
This is cool. Let's change the indicator in other places.
But when I reset, I don't want to be bothered by a prompt. I just want things reset.
We can keep the granularity flags but let's get rid of the prompt.
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
2453d62
to
5bcd325
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
5bcd325
to
b538632
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
2 times, most recently
from
9c45bce
to
9b6e15b
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
9b6e15b
to
e51379a
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
e51379a
to
a2579cd
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
a2579cd
to
5cb32a5
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
5cb32a5
to
fb77b60
Compare
AgentEnder
force-pushed
the
feat/smol-reset
branch
from
fb77b60
to
e5ae718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx resettakes no options, and will always shut down the daemon as well as remove all local cache entries. This isn't great, because it means that the next task gets a full cold start when the user may have just needed to restart the daemon to clear up the issue they are facing.Expected Behavior
nx resetallows users to pick what data is deleted.nx/workspace-datais new project graph cache dirRelated Issue(s)
Fixes #