-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent font flashing in the docs #23622
Prevent font flashing in the docs #23622
Conversation
... by moving the Google font includes near the top of the head. By including them as early as possible, they are known, when the browser starts rendering the body. Test it by making the change manually in `doc/html/system.html` and then press ctrl+f5 (reload without cache). This removes the font flashing. Tested in Chrome and Firefox.
You need to update the tests too via |
... by running `nim c -r -d:nimTestsNimdocFixup nimdoc/tester.nim`
Thanks for the tip. I do not understand the seven failing checks, let me know if that's a problem. |
Seems its the RST tests failing. Same steps except with nim c -r -d:nimTestsNimdocFixup nimdoc/rsttester.nim |
Execution of an external program failed For the records, I get this error too locally, when I run
When I then run the same command again, it succeeds. Let me know if you need precise steps to reproduce. |
Don't worry thats fine. It updates the local files after running the tests. |
@ire4ever1190, but that's what I did. It is the second commit, the current state of this PR. After running the command |
Ah, think you are running the same file twice |
... by running `nim c -r -d:nimTestsNimdocFixup nimdoc/rsttester.nim` twice.
Ah, now I got you, you meant "NILS, DO the same steps ...". I have read it as "I DID the same steps ...". OK, my bad. So, I ran this command twice, and there was indeed another change. I just pushed it. Let's see if it works. Looks good. |
Irrelevant CI failure, merging. |
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
... by moving the Google font includes near the top of the head. By including them as early as possible, they are known, when the browser starts rendering the body.
Test it by making the change manually in
doc/html/system.html
and then press ctrl+f5 (reload without cache). This removes the font flashing.Tested in Chrome and Firefox.