fix(docs): Fix Colemak keyboard distribution #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping seems to be flipped. With the default configuration and only including the mappings, `alt-i` would change to workspace "u" (by mapping to `alt-u`) instead of moving focus right (as expected of `alt-l`) This commit addresses the issue by inverting the mapping declaration.
|
Are you sure that your PR is correct? I have double-checked it and the mapping seems to be correct Keys of the mapping are key notations and values of the mapping are key codes E.g. in Colemak, key |
omar25h
reviewed
May 19, 2024
| k = 'n' | ||
| r = 'm' | ||
| n = 'k' | ||
| m = 'r' |
There was a problem hiding this comment.
I'm using the Colemak layout and the current settings are almost correct. As a matter of fact, I only had to modify this line to avoid having duplicate mapping (r = 's' on line 179 and r = 'm' here)
Suggested change
| m = 'r' | |
| m = 'm' |
There was a problem hiding this comment.
I only had to modify this line to avoid having duplicate mapping (r = 's' on line 179 and r = 'm' here)
Thanks! That is a typo indeed. Should be fixed now 74dc45ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping seems to be flipped.
With the default configuration and only
including the mappings,
alt-iwould change to workspace "u" (by mapping toalt-u) instead ofmoving focus right (as expected of
alt-l)This commit addresses the issue by inverting the mapping declaration.