Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf.py: Set navigation_with_keys to allow navigating documentation through arrow keys #11684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

C0rn3j
Copy link
Contributor

@C0rn3j C0rn3j commented Mar 28, 2024

Feature from sphinx-doc/sphinx#2064.

Signed-off-by: Martin <spleefer90@gmail.com>
@joshtrichards
Copy link
Member

Nice idea. Seems to work reasonably.

The only concern I've come up with: it disables the ability to use the keyboard to scroll sideways when there are big tables (e.g. https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html). The horizontal scrollbar still works there of course.

I don't consider that a showstopper, as I consider those wide tables already to be in need of some other clarity to indicate they can be scrolled (since the scrollbar doesn't even appear - to indicate they're scrollable - unless you roll your cursor in front of the table).

So I'm okay with this. Not sure how others feel about it so I'll leave this PR open a bit before merging so that others can weigh in first.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants