Add configurable KaTeX location #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the math.html partial to conditionally load KaTeX assets from either a local self-hosted or a remote CDN, depending on the 'local_katex' parameter set in the site's configuration. This approach may improve load times and security.
|
@jemos is attempting to deploy a commit to the nanxiaobei's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Please update |
|
Sorry, I've overlooked that 😅 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the theme was using a CDN for the KaTeX library. In context of security it may be preferable to have those libraries locally, from the same domain. I'm open to change this pull-request to work in another way (different variable name, another way of achieving the same result, etc.) if needed.
The patch adds a local_katex variable, which if set, will load the JS/CSS from the base URL. The user of the theme needs to place these files in the page source
static/folder (so it's up to the owner of the site to control the version/files).