Layers: add recursive property #28427
Open
+157
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
May 20, 2024
Mugen87
reviewed
May 20, 2024
CodyJasonBennett
commented
Jun 2, 2024
| @@ -3,6 +3,7 @@ class Layers { | |||
| constructor() { | |||
|
|
|||
| this.mask = 1 | 0; | |||
| this.recursive = false; | |||
There was a problem hiding this comment.
Maybe the default should be configurable with a static property Layers.DEFAULT_RECURSIVE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #18937
Description
Continues #19012 with handling wherever a visibility test is performed. I did not update layers tests in render-lists or transmission pass code since it was not clear to me if those lists were in any hierarchical order.
When
Layers.recursive = truefor an object and it fails the visibility test, its children are not processed.