Changed default value of the startInterval to 5s #47799
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2walker
changed the title
j2walker
changed the title
Signed-off-by: Jack Walker <90711509+j2walker@users.noreply.github.com>
j2walker
force-pushed
the
47648-dameon-health-start-interval-default-value-fix
branch
from
03f6dea
to
e7fe35c
Compare
vvoland
requested changes
May 7, 2024
| @@ -25,6 +25,9 @@ const ( | |||
| // Also the time before the first probe. | |||
| defaultProbeInterval = 30 * time.Second | |||
|
|
|||
| // Default interval between the container starting and the first probe run. | |||
| defaultStartInverval = 5 * time.Second | |||
There was a problem hiding this comment.
Small typo 😅
Suggested change
| defaultStartInverval = 5 * time.Second | |
| defaultStartInterval = 5 * time.Second |
coolljt0725
reviewed
May 7, 2024
| @@ -25,6 +25,9 @@ const ( | |||
| // Also the time before the first probe. | |||
| defaultProbeInterval = 30 * time.Second | |||
|
|
|||
| // Default interval between the container starting and the first probe run. | |||
There was a problem hiding this comment.
The comments seems not correct. Start interval is the time between health checks during the start period https://docs.docker.com/reference/dockerfile/#healthcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Changed the startInterval default value to be 5s
- How I did it
Added a new variable named
defaultStartIntervaland set it to 5s. Before, the default value was set to proveInterval by accident.- How to verify it
Run the container's monitoring thread and check if the startInterval's default value is 5s instead of the original 30s.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)