Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify preconditions during CompleteMultipart #19713

Merged
merged 1 commit into from May 11, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

verify preconditions during CompleteMultipart

Motivation and Context

Bonus: hold the write lock properly to apply
optimistic concurrency during NewMultipartUpload()

How to test this PR?

Verify this by performing concurrent PUTs for both multipart and single
PUT both calls with if-none-match: * set - whoever wins first must
return an error "PrecondFailed"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Bonus: hold the write lock properly to apply
optimistic concurrency during NewMultipartUpload()
@harshavardhana harshavardhana merged commit e8d14c0 into minio:master May 11, 2024
20 checks passed
@harshavardhana harshavardhana deleted the verify-pre-cond branch May 11, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants