Add batch status API #19679
Open
Add batch status API #19679
+188
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#19677 also related. |
vadmeste
force-pushed
the
batch-status
branch
3 times, most recently
from
bbbd717
to
91d3a99
Compare
harshavardhana
requested review from
poornas,
krisis,
harshavardhana,
allanrogerr and
shtripat
harshavardhana
requested changes
May 9, 2024
| @@ -57,6 +58,11 @@ import ( | |||
|
|
|||
| var globalBatchConfig batch.Config | |||
|
|
|||
| const ( | |||
| // Keep the completed/falied job stats 3 days before removing it | |||
| oldJobsExpiration = 3 * 24 * time.Hour | |||
There was a problem hiding this comment.
3 days? 24hr is enough I think.
There was a problem hiding this comment.
@harshavardhana the batch job is a long running job, I doubt users will check the batch status everyday, then once the job batch completes or fails + 24 hours, there is no trace at all about what happened. Maybe we should not remove in the first place and add a new API to remove batch reports
There was a problem hiding this comment.
Yeah for that they must configure notifications, we shouldn't have to carry this around.
Can you check what AWS S3 does?
shtripat
reviewed
May 9, 2024
8 tasks
Currently the status of a completed or failed batch is held in the memory, a simple restart will lose the status and the user will not have any visibility of the job that was long running. In addition to the metrics, add a new API that reads the batch status from the drives. A batch job will be cleaned up three days after completion. Also add the batch type in the batch id, the reason is that the batch job request is removed immediately when the job is finished, then we do not know the type of batch job anymore, hence a difficulty to locate the job report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Currently the status of a completed or failed batch is held in the memory, a simple restart will lose the status and the user will not have any visibility of the job that was long running.
In addition to the metrics, add a new API that reads the batch status from the drives. A batch job will be cleaned up three days after completion.
Also add the batch type in the batch id, the reason is that the batch job request is removed immediately when the job is finished, then we do not know the type of batch job anymore, hence a difficulty to locate the job report
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)