New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster ILM metrics in metrics-v3 #19539
Open
balamurugana
wants to merge
1
commit into
minio:master
Choose a base branch
from
balamurugana:Add-cluster-ilm-metrics-in-metrics-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add cluster ILM metrics in metrics-v3 #19539
balamurugana
wants to merge
1
commit into
minio:master
from
balamurugana:Add-cluster-ilm-metrics-in-metrics-v3
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
April 19, 2024 02:01
8772cb3
to
5569cda
Compare
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
April 26, 2024 04:05
5569cda
to
511eb44
Compare
anjalshireesh
requested changes
May 6, 2024
| `minio_cluster_ilm_transition_active_tasks` | `counter` | Number of active ILM transition tasks | | | ||
| `minio_cluster_ilm_transition_missed_immediate_tasks` | `counter` | Number of missed immediate ILM transition tasks | | | ||
| `minio_cluster_ilm_transition_pending_tasks` | `counter` | Number of pending ILM transition tasks in the queue | | | ||
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions scanned since server start | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions scanned since server start | | | |
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions checked for ilm actions since server start | | |
m.Set(transitionMissedImmediateTasks, float64(globalTransitionState.MissedImmediateTasks())) | ||
m.Set(transitionPendingTasks, float64(globalTransitionState.PendingTasks())) | ||
} | ||
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricApplyVersion))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricApplyVersion))) | |
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricILM))) |
anjalshireesh
requested review from
vadmeste,
krisis,
harshavardhana and
kannappanr
May 6, 2024 13:02
Signed-off-by: Bala.FA <bala@minio.io>
balamurugana
force-pushed
the
Add-cluster-ilm-metrics-in-metrics-v3
branch
from
May 7, 2024 03:10
511eb44
to
d8ef595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Endpoint: /minio/metrics/v3/cluster/ilm
Metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)