Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster ILM metrics in metrics-v3 #19539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balamurugana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Endpoint: /minio/metrics/v3/cluster/ilm
Metrics:

  • expiry_pending_tasks
  • transition_active_tasks
  • transition_missed_immediate_tasks
  • transition_pending_tasks
  • versions_scanned

Motivation and Context

https://github.com/miniohq/engineering/issues/1510

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@balamurugana balamurugana marked this pull request as draft April 18, 2024 03:12
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from 8772cb3 to 5569cda Compare April 19, 2024 02:01
@balamurugana balamurugana marked this pull request as ready for review April 19, 2024 02:02
@balamurugana balamurugana force-pushed the Add-cluster-ilm-metrics-in-metrics-v3 branch from 5569cda to 511eb44 Compare April 26, 2024 04:05
| `minio_cluster_ilm_transition_active_tasks` | `counter` | Number of active ILM transition tasks | |
| `minio_cluster_ilm_transition_missed_immediate_tasks` | `counter` | Number of missed immediate ILM transition tasks | |
| `minio_cluster_ilm_transition_pending_tasks` | `counter` | Number of pending ILM transition tasks in the queue | |
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions scanned since server start | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions scanned since server start | |
| `minio_cluster_ilm_versions_scanned` | `counter` | Total number of object versions checked for ilm actions since server start | |

m.Set(transitionMissedImmediateTasks, float64(globalTransitionState.MissedImmediateTasks()))
m.Set(transitionPendingTasks, float64(globalTransitionState.PendingTasks()))
}
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricApplyVersion)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricApplyVersion)))
m.Set(versionsScanned, float64(globalScannerMetrics.lifetime(scannerMetricILM)))

Signed-off-by: Bala.FA <bala@minio.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants