Add cluster config metrics in metrics-v3 #19507
Open
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
requested review from
donatello,
harshavardhana and
Praveenrajmani
vadmeste
reviewed
Apr 17, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
2 times, most recently
from
041e578
to
5b2c343
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
from
6a0c403
to
f2c3b59
Compare
harshavardhana
requested changes
Apr 28, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
from
f2c3b59
to
3103f9b
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
4 times, most recently
from
06d44c1
to
55ab152
Compare
shtripat
reviewed
May 6, 2024
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
from
434b2dc
to
eb51468
Compare
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
from
c9b27b0
to
c6c8d87
Compare
endpoint: /minio/metrics/v3/cluster/config metrics: - write_quorum - rrs_parity - standard_parity
anjalshireesh
force-pushed
the
metrics-v3-cluster-cfg
branch
from
c6c8d87
to
26e23c4
Compare
klauspost
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
endpoint: /minio/metrics/v3/cluster/config
metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
mc admin prometheus metrics <alias> clustershould return the new cluster config related metrics
(will need some changes in mc to invoke the metrics-v3 api)
Types of changes
Checklist:
commit-idorPR #here)