Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add back cicd image #18740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Timeraa
Copy link

@Timeraa Timeraa commented Jan 4, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

This PR adds back the building of the "edge-cicd" image but under a new name being release.cicd (latest.cicd, RELEASE....cicd) so that you can pin the version in CI/CD to a specific version.

NOTE that I copied over the dockerfile from Dockerfile.release and simply added 2 lines at the bottom.

If documentation should be added let me know and I will try my best to add it!

I never contributed to this repository but I do hope I changed the correct file required for building (docker-buildx.sh) if this is the wrong file please let me know and I shall update it!

Motivation and Context

I noticed that in the past there was a docker image with the tag edge-cicd but it has been stale and isn't updated since more than 2 years now but when writing ci/cd actions that depend on minio (example being tests) you would need to "rely" on the 2 year old container.

How to test this PR?

Simply building the docker image and running it locally should automatically start up minio server directly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@Timeraa Timeraa changed the title feat: cicd image feat: Add back cicd image Jan 4, 2024
@harshavardhana
Copy link
Member

why do you need a new docker image with same binaries?

@Timeraa
Copy link
Author

Timeraa commented Jan 24, 2024

why do you need a new docker image with same binaries?

The docker image is the same as all the other images with the only exception being that its cmd command starts minio directly as in GitHub actions you cannot pass arguments which would allow for the same possibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants