Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Auth Mechanism for ScyllaDB/Cassandra #9231

Merged
merged 3 commits into from
May 21, 2024

Conversation

MinuraPunchihewa
Copy link
Contributor

Description

This PR fixes the auth mechanism for the ScyllaDB handler (and as a result, the Cassandra handler) to enforce it only if the parameters are provided.

Fixes #9215

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

image

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@ZoranPandovski ZoranPandovski merged commit 881ca8a into main May 21, 2024
13 checks passed
@ZoranPandovski ZoranPandovski deleted the bugfix/scylla_cassandra_auth_fix branch May 21, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cassandra Integration Enforces User/Password Even When Authentication is not Enabled
2 participants