-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI Integration Improvements #9225
Conversation
@StpMax I cannot seem to run the fine-tuning test reliably; running into a bunch of errors. So, i've just commented it out for now. |
@ZoranPandovski I believe this is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Before we merge let's remove the openai handler from flake ignore file https://github.com/mindsdb/mindsdb/blob/main/.flake8#L144C1-L144C49, also we can remove the commented test for now
Done. |
Description
This PR improves the OpenAI handler in order to make it Enterprise-ready.
Type of change
Verification Process
To ensure the changes are working as expected:
Test Location:
tests/unit/ml_handlers/test_openai.py
for unit tests andmindsdb/integrations/handlers/openai_handler/tests/test_openai_handler.py
for integration tests.Verification Steps: Run the above test modules (for integration tests, an OpenAI API key will be required).
My code follows the style guidelines(PEP 8) of MindsDB.
I have appropriately commented on my code, especially in complex areas.
Necessary documentation updates are either made or tracked in issues.
Relevant unit and integration tests are updated or added.