-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference to cloud handler #9133
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,9 @@ | |||
__title__ = 'MindsDB Cloud handler' | |||
__package_name__ = 'mindsdb_cloud_handler' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we update the handler folder name to "mindsdb/integrations/handlers/mindsdb_cloud_handler
(instead of "mindsdb_cloud")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the name doesn't make any change since we are not releasing them. I just checked and it is the same in all handlers, so we may decide on keeping only the name without _handler
mindsdb/integrations/handlers/mindsdb_cloud/tests/test_mindsdb_cloud_handler.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZoranPandovski The existing changes look good, but I think we will have to update the unit tests in tests/unit/ml_handlers/test_mindsdb_inference.py
as well?
Moving this to Draft as discussed |
Description
This PR changes the mindsdb inference handler as mindsdb cloud. The handler, README and docs are updated
Type of change
(Please delete options that are not relevant)
Additional Media:
Checklist: