Fix milestone reminder #42861
Merged
Fix milestone reminder #42861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iethree
reviewed
May 23, 2024
nemanjaglumac
commented
Jun 5, 2024
Comment on lines
+82
to
+83
| // Exit as soon as we found an issue without a milestone and alerted the author. | ||
| process.exit(0); |
There was a problem hiding this comment.
@iethree as the alternative, we can let the script go through ALL linked issues and alert for each issue without a milestone individually. WDYT?
There was a problem hiding this comment.
i think one message is sufficient, i like how you did it here 👍
iethree
approved these changes
Jun 6, 2024
Comment on lines
+82
to
+83
| // Exit as soon as we found an issue without a milestone and alerted the author. | ||
| process.exit(0); |
There was a problem hiding this comment.
i think one message is sufficient, i like how you did it here 👍
|
@nemanjaglumac Did you forget to add a milestone to the issue #42835 linked in this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #42835.
The milestone reminder workflow has been broken.
My previous attempt to fix it didn't really work because the parsing logic was wrong.
This is the example:
https://github.com/metabase/metabase/actions/runs/9382661958/job/25834555041#step:2:78
Notice how it tries to fetch
https://api.github.com/repos/metabase/metabase/issues/sSome local experimentation explains why this happened in the past:
I've now included a lot of unit tests to make sure this script is working.
Notable Changes
How to verify
Checklist