Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cmdk v1.0.0 #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NuclearConsent
Copy link

Fixes #173

Package cmdk was updated to v1.0.0 with breaking changes. A couple things needed to be updated to support the major version.

This pull request does the following:


I did not see any contributing guidelines. Please let me know if anything needs to be changed.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sachaw
Copy link
Member

sachaw commented Apr 26, 2024

Hi, thanks for the PR, could you please revert the version bump (needs to be in sync with the firmware) and I'll get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contextual menu items greyed out and cannot be clicked
3 participants