Qr channel select #1038
Qr channel select #1038
Conversation
…s intuitive as the existing components.
…R. The user can select what channels to include when editing channels.
…ment I did not think it was worth it to get the state needed there.
… an update of an empty ChannelSet. To be clear I don't fully understand the behavior behind updating the AppOnlyProtos.ChannelSet.
|
|
I'm not aware of what "add=true" is. Is it something meant to help with the feature? |
It would be so when you add selected channels from a QR code, they’ll be added versus overwriting all channels. It was recently added in the Apple apps: meshtastic/Meshtastic-Apple@2a38dbb |
Understood, These commits don't provide said feature. |
There was a problem hiding this comment.
while the effort is appreciated, this implementation is needlessly complex. the changes to Channel, ChannelSet, and viewmodel are unnecessary. instead, simply filter the checked channels to build a ChannelSet and generate the QR code/URL from that.
also consider using a separate UI screen or modal for channel selection and QR code/URL generation, for example, similar to how it’s done in the web app:
|
Thanks for the feedback at @andrekir , and I appreciate the hard work that has gone into the app. Ill take another crack at it 🏗️ |
|
Took a fresh approach with #1051 |
Addressing Issue #635
These changes allow the user to select what channels they want included in the URL/QR.