-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: call .node to check for node existence #5448
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Unfortunately these changes are still not enough to avoid all the runtime errors related to missing DOM nodes. The fact |
@FezVrasta can you share which issue this PR is trying to solve? |
We are running mermaid on a React application, and we are encountering errors of the kind "cannot read getBBox from undefined". |
Can you post an example mermaid code that has the issue? |
I'm unable to provide a repro at this time, but the PR fixes at least 1 type error (where you are forgetting to call |
📑 Summary
Brief description about the content of your PR.
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch