-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zookeeper ha #3971
Draft
irevoire
wants to merge
71
commits into
main
Choose a base branch
from
zookeeper-ha
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Zookeeper ha #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a lot of comments and logs
Kerollmops
force-pushed
the
zookeeper-ha
branch
from
August 29, 2023 16:17
b50f026
to
61e537f
Compare
Kerollmops
force-pushed
the
zookeeper-ha
branch
from
September 12, 2023 12:46
10c37b4
to
c158d03
Compare
… new release again
… is still not implemented
…and is right), I need to patch the zookeeper client to not rely on tokio anymore
irevoire
added
prototype available
You can test this feature using the available prototype
replication
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What works
We synchronize the API-keys through Zookeeper.
Usage
One new cli flag has been introduced. It’s called
zk-url
and must specify the URL of one of the Zookeeper machines in the cluster.Example usage:
You must create your bucket beforehand.
If needed you can also specify the region of your bucket with the
--s3-region
parameter.Todos
IndexScheduler::new
to really be async (i.e.: use all the tokio thingy instead of using, for example,std::fs
and spawn blocking when needed).run
function, we should be able to return errors instead of panickingWhat zookeepers should look like
auth
to update its api-key accordingly to the zookeeper's fs in case of creation, update, or deletion.tasks
to insert the last enqueued tasks to its task queueelection
is used to run a leader election. Read more about the leader election process here: https://zookeeper.apache.org/doc/current/recipes.html#sc_leaderElectionsnapshots
should be watched by everyone to pull the latest snapshot every time the leader finishes processing a taskWhat the S3 should look like
snapshot-{XX}
directory with all the databases.related to #3494