Added options to constructor #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new `sensorState` event to deliver light sensor illumination values,
and added `requestUpdate` function for getting a fresh report from the gateway.
Consumers should probably ensure they are using `gateway.once('ready', ...)`
instead of `gateway.on('ready', ...)` to avoid processing multiple 'ready'
events for the same gateway.
marvinroger
requested changes
Jun 7, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "lumi-aqara", | |||
| "description": "Control your Xiaomi Smart Home devices with this Lumi Aqara library", | |||
| "version": "0.0.0-development", | |||
| "version": "1.7.0", | |||
There was a problem hiding this comment.
Can you delete this change ? The versioning is done automatically by semantic-release. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options in the constructor:
bindHost: currently the app binds only to 0.0.0.0. Made it possible to override this.
unbindHosts: i'm not very familiar with the term here but you can rename it if you please. In my use case addMembership is causing an 'address already in use error' when another
app is using an existing interface for multicasing.