Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run opensfm for windows #574

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Run opensfm for windows #574

wants to merge 3 commits into from

Conversation

kjkim-kr
Copy link

@kjkim-kr kjkim-kr commented Apr 9, 2020

I have checked at Ubuntu 16.04, two values(13598720) are equal

`Python 3.5.2 (default, Oct 8 2019, 13:06:37)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.

import os
import resource
import psutil
resource.getrusage(resource.RUSAGE_SELF).ru_maxrss * 1024
13598720
psutil.Process(os.getpid()).memory_info().rss
13598720

`

and psutil also runs successfully at Windows

`Microsoft Windows [Version 10.0.17134.950]
(c) 2018 Microsoft Corporation. All rights reserved.

C:\Users\KJ>python
Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 03:37:03) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import psutil
import os
psutil.Process(os.getpid()).memory_info().rss
15052800

`

@paulinus
Copy link
Member

Tests fail because psutil is not in requirements.txt

@kjkim-kr, did you manage to run opensfm successfully after this fix? If so we could consider adding the dependency.

@kjkim-kr
Copy link
Author

kjkim-kr commented Apr 17, 2020

@paulinus thanks, I didn't know that as I'm poor at using github yet, I will modify it.

Here are log images when I run opensfm after modifying resource to psutil both Windows and Ubuntu

Windows
Ubuntu

@facebook-github-bot
Copy link
Contributor

Hi @kjkim-kr!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@JakeSmarter
Copy link
Contributor

JakeSmarter commented Jul 17, 2020

Please, would it be possible for you to share a simple guide on how to do this build? for example, pointing the sequence of steps that you did.

@felipe-carvalho Since I am currently a bit stuck on Windows, I am also trying to build OpenSfM on Windows. I am basically able to build OpenSfM with MinGW. The only issue I have run into so far is an ABI issue where ld is unable to link against OpenCV and Ceres as pre-built binary dependencies. The dependencies are built with Microsoft Visual C++ which has no stable ABI, but only since version 14 or later (Microsoft Visual C++ 2015). ld does not support Microsoft's latest C++ ABI yet but there is a workaround I am currently working on. I do not want to build OpenCV and Ceres myself because especially OpenCV is quite complex to build (CMake is not of much help here either 😞).

As soon as I get it running I am going create a PR so that we should have a build path for Windows.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants