Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For clusters, allow --wait to be passed down #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emschwar
Copy link

This comprises two related changes:

  • For individual servers, use --wait to timeout a start or stop effort.
  • For clusters, pass the --wait parameter down to each cluster's stop/start/restart
    command.

(Fixes #310)

This comprises two related changes:

- For individual servers, use --wait to timeout a start or stop effort.
- For clusters, pass the --wait parameter down to each cluster's stop/start/restart
  command.
@emschwar
Copy link
Author

Running specs shows this failure:

1)
Errno::EPROTOTYPE in 'Thin::Server robustness should not crash when header too large'
Protocol wrong type for socket
spec/server/robustness_spec.rb:19:in `write'
spec/server/robustness_spec.rb:19:in `block (4 levels) in <top (required)>'
spec/server/robustness_spec.rb:18:in `times'
spec/server/robustness_spec.rb:18:in `block (3 levels) in <top (required)>'
spec/server/robustness_spec.rb:12:in `times'
spec/server/robustness_spec.rb:12:in `block (2 levels) in <top (required)>'

I think it may be just my environment, since I'm pretty sure I didn't change anything that would have affected this test, but I'm happy to make any additional fixes if it's a real problem.

@ioquatix
Copy link
Collaborator

ioquatix commented Sep 7, 2020

Can you please rebase this on master?

@emschwar
Copy link
Author

emschwar commented Sep 8, 2020

Done.

@ioquatix
Copy link
Collaborator

ioquatix commented Sep 8, 2020

Errno::EPROTOTYPE in 'Thin::Server robustness should not crash when header too large'

This is actually a bug in the MacOS network stack due to deferred resource allocation - you get a very weird error because that is actually the point where the socket is created, and the error occurs... it comes out of an "unrelated" system call.

Thanks for rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterController uses :wait for starting, but not stopping (or restarting)
2 participants