fix (dave2d) : remove __NOP(); and __BKPT(0); #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C47D
reviewed
May 20, 2024
| @@ -45,7 +45,7 @@ d2_color lv_draw_dave2d_lv_colour_to_d2_colour(lv_color_t color) | |||
| /*Color depth: 8 (A8), 16 (RGB565), 24 (RGB888), 32 (XRGB8888)*/ | |||
| switch(LV_COLOR_DEPTH) { | |||
| case(8): | |||
| __BKPT(0); | |||
| LV_ASSERT(1 == 0); | |||
There was a problem hiding this comment.
Can this be reduced to LV_ASSERT(0)?
C47D
reviewed
May 20, 2024
| @@ -113,7 +113,7 @@ d2_u32 lv_draw_dave2d_lv_colour_fmt_to_d2_fmt(lv_color_format_t colour_format) | |||
| break; | |||
|
|
|||
| default: | |||
| __BKPT(0); | |||
| LV_ASSERT(1 == 0); | |||
There was a problem hiding this comment.
Can this be reduced to LV_ASSERT(0)?
C47D
reviewed
May 20, 2024
| @@ -129,7 +127,7 @@ void lv_draw_dave2d_triangle(lv_draw_dave2d_unit_t * u, const lv_draw_triangle_d | |||
| } | |||
| else if(LV_GRAD_DIR_HOR == dsc->bg_grad.dir) { | |||
| /* TODO */ | |||
| __BKPT(0); | |||
| LV_ASSERT(1 == 0); | |||
There was a problem hiding this comment.
Can this be reduced to LV_ASSERT(0)?
C47D
reviewed
May 20, 2024
| @@ -112,7 +110,7 @@ void lv_draw_dave2d_triangle(lv_draw_dave2d_unit_t * u, const lv_draw_triangle_d | |||
|
|
|||
| if(a1 < a2) { | |||
| /* TODO */ | |||
| __BKPT(0); | |||
| LV_ASSERT(1 == 0); | |||
There was a problem hiding this comment.
Can this be reduced to LV_ASSERT(0)?
kisvegabor
previously approved these changes
May 22, 2024
kisvegabor
changed the title
C47D
approved these changes
May 24, 2024
XuNeo
reviewed
May 24, 2024
XuNeo
approved these changes
May 24, 2024
kisvegabor
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
fix (Dave2D) : Remove __NOP(); from the Dave2D code
Remove ARM __NOP(); from Dave2D code, to make compiling for RX core cleaner
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.