Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some features and fixes #569

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

pduchnovsky
Copy link
Contributor

@pduchnovsky pduchnovsky commented May 7, 2021

Prerequisites

  • This pull request adds a feature.
  • This pull request fixes certain issues.

Description

  • Some very minor changes in css
  • Removed prefetch-src CSP since its deprecated and unsupported by any browser
  • Added support for "mailto:" e.g. 'Contact me' menu links.
    e.g.: image
  • Lowered text size of footer on mobile devices.
    e.g. before and after:
    image

Issues Resolved

  • Defined avatar width and height so content doesn't 'jump' during page/image loading.
  • Added pagination li padding for more easily 'clickable' pagination links on mobile devices and some other minor changes.
    e.g. before and after:
    image
  • Increased size of avatar on mobile devices so it does not look so small.
    e.g. before and after:
    image

Checklist

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

@pduchnovsky pduchnovsky changed the title some features some features and fixes May 7, 2021
@luizdepra
Copy link
Owner

I'm going to need to merge this PR in a separated branch, and then I can cherry-pick the changes I find interesting.
I'll come back here later.

@pduchnovsky
Copy link
Contributor Author

Just a note, this is ready to be merged still :D I think the changes are pretty useful, not sure what's the blocker ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants