-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket test script #92
base: master
Are you sure you want to change the base?
socket test script #92
Conversation
* specs/posix_spec.yaml (socket handling): New spec, not working on Mountain Lion, at least :( Awaiting feedback, see issue #92. Reported by zevv@github, from a patch by Ico Doornekamp. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
I'd have to look into the details, but my guess is that this stuff is hard to test as a standalone unit. To be able to test IPv6 the host should have IPv6 connectivity configured and enabled, and should allow the tests to bind ports and connect to the outside world. Not sure if this is something which can be properly tested with something like Travis... |
Thanks for the swift response! :) I think its more to do with whether the luaposix socket calls provide everything needed to check whether the functionality required is available before trying to run an unsupported test. This is surely possible with C, so if it can't (yet) be done with luaposix from the Lua side, then I see no technical reason why it can't be fixed by exposing the APIs that C would use to make the pre-test checks. Plainly, Mac OS has perfectly functional sockets, and most Linux software compiles on the Mac with very little patching (ref. Homebrew). If I need to add a I sometimes hear the term: a simple matter of programming ;-) |
Actually, an explicit skip function is not required in recent Specl, because it only reports on examples that fire - describe ipv6 only functionality:
if posix.IPPROTO_IPV6 then
expect (ipv6 stuff).to_contain (ipv6 only results)
end And reporting will automatically elide that test case if the expect is not reached. |
The test for this issue started passing unexpectedly for me, since I merged today's commits. |
It passes unexpectedly for me on my dev machines, but fails on Travis (Ubuntu Precise?) last I checked. |
See https://travis-ci.org/luaposix/luaposix/jobs/51387861 : one appears to be passing, but not the other (unless I am misreading the log). |
e9e663d
to
717ec3e
Compare
452fc21
to
c0429e9
Compare
948ec35
to
898831b
Compare
1c3cf95
to
5d5e06e
Compare
ccdf35d
to
b424672
Compare
No description provided.