Clarify doc for getgrgid/getgrnam/getpwuid/getpwnam when the group/user does not exist #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the doc for getgrgid()/getgrnam() when the group does not exist
Clarify doc of getpwuid()/getpwnam() when the user does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The posix spec says that the C functions should return NULL and not change errno when the group/user does not exist.
The wrappers set errno to 0 before the call, so the current expected behavior when the group/user does not exist is to return a single nil
The doc has been updated to reflect that
The C functions are used in a few other places, but they treat a missing group/user and an error in the same way, so it's fine
The wrappers are not reused anywhere
The lua functions are only used in tests and there are already tests for this special case