Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrapper of execve to be able to specify the environment of the new process. I'm not convinced this is good code: should the Lua strings, used to fill the C array envp, be removed from the stack before (or after) execve? Surely when execv returns (in case of error) there will be more values on the stack than reported by the return value of the function?
Also, valgrind reports errors with my function but not with unistd.exec, I'm not sure why (both leave extra Lua strings on the stack).
Also, would it be better to change
unistd.exec
to have an optionalenv
arg rather than a separateunistd.exece
function?