updated instructions and image of adapters #56
Conversation
Signed-off-by: asubedy <frexpe@pm.me>
Signed-off-by: asubedy <frexpe@pm.me>
@leecalcote I am thinking of putting the above note(in this way itself) after the install command for this issue |
Signed-off-by: asubedy <frexpe@pm.me>
|
The last commit dealt with these changes:
|
There was a problem hiding this comment.
Good work @asubedy, just a nitpick could you please hyphenate the file name install image-hub.
| "uilayout": "terminal-iframe" | ||
| }, | ||
|
|
||
| "backend": { | ||
| "imageid": "kubernetes-cluster-running:1.18" | ||
| "imageid": "kubernetes-cluster-running:1.22" |
There was a problem hiding this comment.
we took this image from the katacoda library, are you sure this works?
There was a problem hiding this comment.
It was suggested by @piyushsingariya. And it is the only line of code I saw that mentioned the version of Kubernetes. So I guess it should work 🤞
There was a problem hiding this comment.
This might be out of date, but here it is - https://www.katacoda.community/essentials/environments.html
There was a problem hiding this comment.
Yes, the docs only mention about 1.18 version. What should we do? The other adapters will work fine but OSM requires kubernetes >=1.19.
There was a problem hiding this comment.
Should we disable OSM lab for some time until we figure some solution out and keep the other labs running with the Kubernetes version 1.18?
There was a problem hiding this comment.
@leecalcote @warunicorn19 thoughts on this approach?
There was a problem hiding this comment.
yes, I think we should remove the OSM lab for the time being, since it doesn't work and I don't see a workaround either. @leecalcote ?
There was a problem hiding this comment.
The trafeik-mesh adapter too. It's still not connecting after the install command.
There was a problem hiding this comment.
I don't know that the OSM installations are working in the Meshery Adapter for OSM even on later K8s versions. @Aisuko, @Revolyssup, is it?
Co-authored-by: warunicorn19 <speak2adi@gmail.com>
|
@asubedy don't worry about DCO here. We'll get you covered. |
Co-authored-by: warunicorn19 <speak2adi@gmail.com>
|
@Revolyssup, please track down the issue with OSM in the Meshery Adapter for OSM. |
leecalcote
added
the
area/lifecycle
|
@asubedy will you open an issue with adapter logs on |
How do I see the adapter logs? From the katacoda scenario or from my local machine? |
What's the issue with OSM adapter? |
When trying to install OSM Servive mesh we get an error, that says we require Kubernetes version greater than or equal to 1.19. This is because on the lab we are using the pre runnung cluster version of 1.18. And there are no image of other version of kubernetes mentioned on the katacoda docs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
stale
bot
removed
the
issue/stale
|
This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go. |
Signed-off-by: asubedy frexpe@pm.me
Description
Updated Instructions and images of adapters
This PR fixes #51
Notes for Reviewers
The PR is not completed yet, as of now Linkerd and NSM are updated. I will be updating the same after each adapter instructions are updated
Signed commits