Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Note attachments screen: Allow searching for attachments #10442

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented May 17, 2024

Summary

This pull request adds a "search" input to the note attachments screen that allows filtering attachments by ID and title.

Note

This was originally implemented a few months ago to help debug #10052. A pull request has been opened now in response to this feature being requested on the forum.

Screen recording

resource-search.mp4

Testing plan

This pull request has been tested manually by:

  1. Creating a large number of resources:
    • This was done from Joplin's development tools with code similar to:
    for (let i = 0; i < 10000; i++) {
        await Resource.save({ title: "Test 2." + i, mime: "text/plain" });
        console.log('created', i);
    }
    
  2. Opening Tools > Note attachments
  3. Searching for "Test"
  4. Copying part of the ID of a resource.
  5. Searching for that ID.

@laurent22 laurent22 merged commit 2dd27cd into laurent22:dev May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants