Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dns): listen on both ipv6 and ipv4 if possible #8978

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(dns): listen on both ipv6 and ipv4 if possible #8978

wants to merge 2 commits into from

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jan 22, 2024 •
edited

My thinking:

IPv6 DP IPv4 DP
Dual stack IPv4 compat enabled, listening on both 👍 listening only on 127.0.0.1, shouldn't need IPv6 address ❓
IPv4 only User ERROR listening only on 127.0.0.1, can't have IPv6 address anyway 👍
IPv6 only IPv4 compat enabled, listening on IPv6 👍 User ERROR

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Fixes DNS listener seems to only be bound to IPv4 #8064
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont
fix(dns): listen on both ipv6 and ipv4 if possible
57066dd 
We only care about this if we have IPv6 _only_ and in this case the
Dataplane address will be IPv6, so that's a sufficient check.
If the Dataplane address _isn't_ IPv6, it should be OK to listen on
IPv4 only, even if it's a dual stack.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge branch 'master' into fix/dns-ipv6
2ff2063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS listener seems to only be bound to IPv4
1 participant
@michaelbeaumont