New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(stability): add target to focus and repeat new or modified tests #6418
Draft
slonka
wants to merge
8
commits into
kumahq:master
Choose a base branch
from
slonka:focus-and-repeat-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slonka <slonka@users.noreply.github.com>
…tests Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
slonka
added
the
ci/skip-test
PR: Don't run unit and e2e tests (maybe this is just a doc change)
label
Mar 31, 2023
@slonka what is the status of this PR? How much work is still needed to finish it? |
Hey, it was pretty much in a working state. Maybe we could talk about this during one of the team meetings. |
closing as people did not ask for this nor did I use this, might reopen in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new target to focus and repeat tests. I hope that this will help us preventing introducing flakes in the first place.
How to tests this change:
make TEST_LIST_BRANCH_TO_DIFF_AGAINST=focus-and-repeat-tests test/e2e/prevent-flakes
#wherefocus-and-repeat-tests
is the branch checked out in 1The next step would be to put this in
circleci
config and run alongside e2e tests, but for this to work the target needs to be inmaster
(orTEST_LIST_BRANCH_TO_DIFF_AGAINST
) branch.In the future this could be extended to include tests that contents have changed (by using git diff, line number and matching that to the nearest tests) or even changed functionality by checking the dependency tree.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?