Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MeshHttpRoute): don't split header value prematurely #10191

Merged
merged 4 commits into from May 14, 2024

Conversation

spacewander
Copy link
Contributor

@spacewander spacewander commented May 7, 2024

Fix #10156
Signed-off-by: spacewander spacewanderlzx@gmail.com

Checklist prior to review

  • #10156 as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Fix kumahq#10156
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review May 7, 2024 13:10
@spacewander spacewander requested a review from a team as a code owner May 7, 2024 13:10
@spacewander spacewander requested review from michaelbeaumont, slonka and lobkovilya and removed request for a team May 7, 2024 13:10
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Copy link
Contributor Author

Will fix the unit test later.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@lahabana lahabana changed the title fix(meshhttproute): don't split header value prematurely fix(MeshHttpRoute): don't split header value prematurely May 13, 2024
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the issue:

I think Envoy will do the right thing here, we should change this.

@michaelbeaumont did you by any chance had time to check if it does the right thing?

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @spacewander !

@michaelbeaumont michaelbeaumont merged commit adc094d into kumahq:master May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When modifying the headers, split the value may cause unexpected bug
4 participants