Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update go to 1.22.2 #10096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

Update Go. Dependabot PRs are failing because it's trying to add toolchain directive and golangci-lint is missing file. I think we need to add this directive as well, but let's first upgrade Go.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 26, 2024 10:19
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen, slonka and lobkovilya and removed request for a team April 26, 2024 10:19
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slonka
Copy link
Contributor

slonka commented Apr 29, 2024

We can't do it for now:

Should we put it in the comments in go.mod / CI config that we can't upgrade yet? I forgot about this and if Bart did not review I would've probably approved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants