Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve openTelemetry installation command #1797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented May 20, 2024

Refer to openTelemetry helm installation UPGRADING, the openTelemetry helm requires the parameter image.repository must be set.

Notice: There are 2 options for this parameter, and OpenTelemetry Collector Kubernetes Distro will be the default image used for the chart(And we also need to update our OpenTelemetry collector configuration). Currently, we use Contrib distribution for transitions.

OpenTelemetry Collector Kubernetes Distro

image:
  repository: "otel/opentelemetry-collector-k8s"

Contrib distribution

image:
  repository: "otel/opentelemetry-collector-contrib"

close #1796

Did you sign your commit? Instructions yes

Have you read Contributing guidelines? yes

@Icarus9913 Icarus9913 requested a review from a team as a code owner May 20, 2024 09:30
@Icarus9913 Icarus9913 requested review from johncowen and lobkovilya and removed request for a team May 20, 2024 09:30
Copy link

netlify bot commented May 20, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit a13f3b3
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/665d2777057c3e000877f033
😎 Deploy Preview https://deploy-preview-1797--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 16 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Icarus9913 Icarus9913 changed the title improve openTelemetry installation command chore(docs): improve openTelemetry installation command May 20, 2024
@Icarus9913
Copy link
Contributor Author

cc @Automaat

Signed-off-by: Icarus Wu <icaruswu66@qq.com>
@Icarus9913
Copy link
Contributor Author

Run $(go env GOPATH)/bin/muffet \
https://deploy-preview-1797--kuma.netlify.app/docs/dev/quickstart/kubernetes-demo/
	timeout	https://kind.sigs.k8s.io/
https://deploy-preview-1797--kuma.netlify.app/docs/2.7.x/quickstart/kubernetes-demo/
	timeout	https://kind.sigs.k8s.io/
https://deploy-preview-1797--kuma.netlify.app/docs/dev/guides/migration-to-the-new-policies/
	timeout	https://kind.sigs.k8s.io/
https://deploy-preview-1797--kuma.netlify.app/docs/2.7.x/guides/migration-to-the-new-policies/
	timeout	https://kind.sigs.k8s.io/

Need re-run for that github action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve openTelemetry installation command with helm
2 participants