-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cue structure implemented #6441
base: master
Are you sure you want to change the base?
Conversation
@anoop2811 please take a look. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6441 +/- ##
===========================================
+ Coverage 33.12% 61.51% +28.39%
===========================================
Files 141 178 +37
Lines 16402 23672 +7270
===========================================
+ Hits 5433 14562 +9129
+ Misses 10285 7679 -2606
- Partials 684 1431 +747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
5878289
to
11e2fe2
Compare
- "spec.template.spec.containers[0].image" | ||
cue: | ||
template: | | ||
apiVersion: "apps/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be wrapped in output
.
} | ||
} | ||
} | ||
parameters: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters is not an array but a map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please give more info on how this was tested?
cue: | ||
template: | | ||
apiVersion: "apps/v1" | ||
kind: "Deployment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take care of indenting and trailing whitespaces?
cue: | ||
template: | | ||
apiVersion: "apps/v1" | ||
kind: "Deployment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take care of indenting and trailing whitespaces?
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
you can test and validate the result by |
Hi @kartikaysaxena , could you please add how you tested these changes? |
Fixes #6436
Implemented cue structure in the docs as per the issue.