Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "remove legacycloudproviders from staging"" #124886

Merged
merged 1 commit into from
May 15, 2024
Merged

Revert "Revert "remove legacycloudproviders from staging"" #124886

merged 1 commit into from
May 15, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 15, 2024 •
edited

This reverts commit d9a0be3.

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

kubernetes/publishing-bot#434 enhances rules.yaml release branch validation to decouple from changes in k/k.

Which issue(s) this PR fixes:

Part of #124771

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed legacy cloud provider integration code (undoing a previous reverted commit)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2024
@k8s-ci-robot k8s-ci-robot requested review from cheftako, johnbelamaric and a team May 15, 2024 12:16
@carlory
Copy link
Member Author

carlory commented May 15, 2024

/cc @dims @cpanato @saschagrunert

@dims
Copy link
Member

dims commented May 15, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 644dc33a2e87229d7485f220f49459e1e74c5ca8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, carlory, dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akhilerm
Copy link
Member

/retest

@carlory
Copy link
Member Author

carlory commented May 15, 2024

/test pull-kubernetes-unit

@carlory
Copy link
Member Author

carlory commented May 15, 2024

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit 1772e3f into kubernetes:master May 15, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 15, 2024
@sftim
Copy link
Contributor

sftim commented Jun 1, 2024

Changelog suggestion

-Revert "Revert "remove legacycloudproviders from staging""
+Removed legacy cloud provider integration code (undoing a previous reverted commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@akhilerm akhilerm akhilerm approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@cpanato cpanato Awaiting requested review from cpanato

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carlory @k8s-ci-robot @dims @akhilerm @sftim @saschagrunert