Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4222: Decode CBOR to UnstructuredList as UnstructuredJSONScheme does. #124775

Merged
merged 1 commit into from
May 23, 2024
Merged

KEP-4222: Decode CBOR to UnstructuredList as UnstructuredJSONScheme does. #124775

merged 1 commit into from
May 23, 2024

Commits on May 13, 2024

  1. Decode CBOR to UnstructuredList as UnstructuredJSONScheme does. 

    Decoding to map[string]interface{} and passing the result to UnstructuredList's
SetUnstructuredContent method does not produce objects that are identical to those produced by
UnstructuredJSONScheme's decode method. UnstructuredJSONScheme's decode:

1. removes the "items" key from the map in its Object field

2. sets "apiVersion" and "kind" (determined heuristically from the list's GVK) on elements of its
Items slice that were not serialized with a nonempty string "apiVersion" and "kind"

3. returns a missing kind error if any element is missing "kind"
    @benluddy
    benluddy committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7e6b866 View commit details
    Browse the repository at this point in the history