Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document of NewExponentialBackoffManager #124773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update document of NewExponentialBackoffManager #124773

wants to merge 1 commit into from
+6 −6

Conversation

ah8ad3
Copy link
Member

@ah8ad3 ah8ad3 commented May 9, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I wanted to use wait.BackoffUntil with exponential and saw this document, tried it but doesn't work. It suggests to use in replace of some deprecated function.
I'm not sure if my suggested document is the exact same of previous one.

Fixes #117829

Special notes for your reviewer:

Any suggestions here would be appreciated. If the PR is not acceptable feel free to close it.

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ah8ad3
Once this PR has been reviewed and has the lgtm label, please assign apelisse for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented May 10, 2024

/retest

@fedebongio
Copy link
Contributor

/assign @MikeSpreitzer @tkashem
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
tkashem
tkashem reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@tkashem tkashem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to address #117829 if I am not mistaken

staging/src/k8s.io/apimachinery/pkg/util/wait/backoff.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented May 15, 2024 •
edited

This seems to address #117829 if I am not mistaken

Yes it seems the issue for this (added the Fixes part), i noticed this when i was using it on another PR and spent some time to understand what is going on here.

Also the comment addressed PTAL. @tkashem

@k8s-ci-robot
Copy link
Contributor

@ah8ad3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-ipv6 94f76f4 link true /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkashem tkashem tkashem left review comments

@liggitt liggitt Awaiting requested review from liggitt

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@tkashem tkashem

@MikeSpreitzer MikeSpreitzer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid deprecation information in k8s.io/apimachinery/pkg/util/wait
5 participants
@ah8ad3 @k8s-ci-robot @fedebongio @tkashem @MikeSpreitzer