Manual cherry pick of #124559 upstream release 1.28

[chengjoey]

Manual cherry pick of #124559 on release-1.28.
#124559 : hotfix when a plugin (in-tree or out-of-tree) return non-existent/illegal nodes, the pod scheduling flow will abort immediately

Does this PR introduce a user-facing change?

Fixed a bug that a pod may remain unscheduled if any PreFilter plugin returns nodes that do not exist.

[k8s-ci-robot]

Hi @chengjoey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alculquicondor]

/lgtm
/approve
/cc kubernetes/release-managers

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 450ada2154c96df3e976a51face7472c7d9f27f4

[alculquicondor]

/ok-to-test

[alculquicondor]

/kind regression

[chengjoey]

/test pull-kubernetes-integration-go-compatibility

[alculquicondor]

I guess the access mode doesn't matter for the purpose of this test?

[chengjoey]

hi @alculquicondor ,
Using ReadWriteOncePod access mode in 1.28 and 1.27 will report the following error:

cannot create pv: PersistentVolume "pv-has-non-existent-nodes" is invalid: spec.accessModes: Unsupported value: "ReadWriteOncePod": supported values: "ReadOnlyMany", "ReadWriteMany", "ReadWriteOnce"

ReadWriteOncePod is fearue gate in 1.28,1.27, so i change this to ReadWriteMany

kubernetes/pkg/apis/core/validation/validation.go

Lines 1670 to 1673 in 73dadc3

	func ValidationOptionsForPersistentVolume(pv, oldPv *core.PersistentVolume) PersistentVolumeSpecValidationOptions {
	opts := PersistentVolumeSpecValidationOptions{
	AllowReadWriteOncePod: utilfeature.DefaultFeatureGate.Enabled(features.ReadWriteOncePod),
	}

[alculquicondor]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6715f119ae546177f0508bb6e90caaae7a429d43

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, chengjoey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [alculquicondor]
• test/e2e/scheduling/OWNERS [alculquicondor]
• test/integration/scheduler/OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Verolop]

/lgtm

[k8s-ci-robot]

@chengjoey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-node-e2e-containerd	02c796c	link	unknown	/test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gce	02c796c	link	unknown	/test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Verolop]

/retest-required