Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: backport generic controlplane to 1.30 #124746

Draft
wants to merge 16 commits into
base: release-1.30
Choose a base branch
from
Draft

WIP: backport generic controlplane to 1.30 #124746

wants to merge 16 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 8, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

sttts added 16 commits May 8, 2024 11:32
@sttts
pkg/controlplane: split up config into generic controlplane and kube-…
9c7652a 
…related part

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Address comments
f27c61d 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
kube-apiserver/aggregator: remove unused PeerCAFile in config
389bcb8 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
controlplane/apiserver: move peer proxy code to allow aggregator cons…
a2de785 
…truction

This reverts commit 0bb6ff5e454cfc99c0b611e22162391eaa31e103.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
controlplane: split out SystemNamespaces
4b93692 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
pkg/controlplane: split apart generic server part of instance.go
68cda7b 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
aggregator: split API priority map into generic and non-generic
5c64f75 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Address comments
c9356f2 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
controlplane: return client error
aa44790 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
controlplane: cosmetics
62d83f5 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
kube-apiserver/aggregator: fix panic with crds disabled
e192f9c 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
kube-apiserver: split admission initializers into generic and non-gen…
736f1f8 
…eric

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
kube-apiserver: split up config creation into generic and non-generic…
385364d 
… part

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
aggregator: move construction to generic controlplane
cbf353c 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
Make linter happy
10317f5 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts
controlplane/apiserver: unify options package name
524f80b 
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 8, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from aojea May 8, 2024 10:11
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2024
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-linter-hints 524f80b link false /test pull-kubernetes-linter-hints
pull-kubernetes-unit 524f80b link true /test pull-kubernetes-unit
pull-kubernetes-unit-go-compatibility 524f80b link true /test pull-kubernetes-unit-go-compatibility

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented May 9, 2024

this is just for experimenting / exercising CI, right? (not intending to merge as a backport)

@sttts
Copy link
Contributor Author

sttts commented May 10, 2024

Right. We need it from a stable branch. It‘s not meant to merge.

@sttts sttts marked this pull request as draft May 10, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@aojea aojea Awaiting requested review from aojea

Assignees
No one assigned
Labels
area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sttts @k8s-ci-robot @liggitt