Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make borrowing by exempt match the KEP #124737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make borrowing by exempt match the KEP #124737

wants to merge 1 commit into from

Conversation

MikeSpreitzer
Copy link
Member

@MikeSpreitzer MikeSpreitzer commented May 8, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR changes the way that exempt priority levels in API Priority and Fairness borrow from non-exempt ones, to match what is in the KEP (https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1040-priority-and-fairness#dispatching).

This is one possible way to resolve the difference. Another possible way is to meet in the middle, as in #124736 and kubernetes/enhancements#4623 .

Which issue(s) this PR fixes:

Fixes #124125

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1040-priority-and-fairness

@MikeSpreitzer
Make borrowing by exempt match the KEP
9c19764 
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 8, 2024
@MikeSpreitzer
Copy link
Member Author

/cc @wojtek-t
/cc @tkashem

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2024
@MikeSpreitzer
Copy link
Member Author

/uncc @yue9944882

@k8s-ci-robot k8s-ci-robot removed the request for review from yue9944882 May 8, 2024 07:02
@MikeSpreitzer
Copy link
Member Author

@kubernetes/sig-api-machinery-misc

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 8, 2024
@fedebongio
Copy link
Contributor

/assign @tkashem @wojtek-t
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@MikeSpreitzer
Copy link
Member Author

@MikeSpreitzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkashem tkashem Awaiting requested review from tkashem

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@tkashem tkashem

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APF borrowing by exempt does not match KEP
5 participants
@MikeSpreitzer @k8s-ci-robot @fedebongio @tkashem @wojtek-t